Skip to content

breaking: Delete filestoredb references [TAROT-3615]#819

Closed
afsmeira wants to merge 1 commit intomasterfrom
am/breaking/tarot3615
Closed

breaking: Delete filestoredb references [TAROT-3615]#819
afsmeira wants to merge 1 commit intomasterfrom
am/breaking/tarot3615

Conversation

@afsmeira
Copy link
Copy Markdown
Contributor

@afsmeira afsmeira commented Dec 18, 2025

@codacy/reliability please advise on the consequences of this PR.

Note that the RDS instance itself has not been deleted.

@afsmeira afsmeira requested review from a team, CallMeLeopoldo, jorgebraz, kendrickcurtis and ricardobernardino2024 and removed request for a team December 18, 2025 16:03
@afsmeira afsmeira requested a review from a team as a code owner December 18, 2025 16:03
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Dec 18, 2025

Codacy's Analysis Summary

0 new issue (≤ 1 medium issue)
0 new security issue (≤ 0 issue)

Review Pull Request in Codacy →

✨ AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.

CallMeLeopoldo
CallMeLeopoldo reviewed Dec 18, 2025
View reviewed changes
@CallMeLeopoldo
Copy link
Copy Markdown
Contributor

CallMeLeopoldo commented Dec 18, 2025

Also, if the PR does not delete the database, we should rename the PR to better describe what we are doing in it 😄

@afsmeira afsmeira changed the title breaking: Delete filestoredb [TAROT-3615] breaking: Delete filestoredb references [TAROT-3615] Dec 18, 2025
@afsmeira
Copy link
Copy Markdown
Contributor Author

afsmeira commented Dec 19, 2025

If I understand the CI failure correctly, it should by fixed by #818 .

@afsmeira
Copy link
Copy Markdown
Contributor Author

afsmeira commented Dec 23, 2025 •
edited
Loading

I was told that this repo is used to deploy self-hosted Codacy, which still uses filestoredb, so I should not remove references to it.

@codacy/reliability @codacy/macgyvers can you confirm?

@CallMeLeopoldo
Copy link
Copy Markdown
Contributor

CallMeLeopoldo commented Dec 23, 2025

If I understand the CI failure correctly, it should by fixed by #818 .

When the PR is merged, yes 😄

@CallMeLeopoldo
Copy link
Copy Markdown
Contributor

CallMeLeopoldo commented Dec 23, 2025

I was told that this repo is used to deploy self-hosted Codacy, which still uses filestoredb, so I should not remove references to it.

@codacy/reliability @codacy/macgyvers can you confirm?

Ah, I believed the filestoredb was also to be removed from the self-hosted option. My fault there for not questioning it. Yes, in this repo we configure the self-hosted filestoredb that is used under Digital Ocean. We definitely should not touch it.

@afsmeira afsmeira closed this Dec 23, 2025
@afsmeira afsmeira deleted the am/breaking/tarot3615 branch December 23, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CallMeLeopoldo CallMeLeopoldo CallMeLeopoldo left review comments

@jorgebraz jorgebraz Awaiting requested review from jorgebraz jorgebraz was automatically assigned from codacy/reliability

@kendrickcurtis kendrickcurtis Awaiting requested review from kendrickcurtis kendrickcurtis was automatically assigned from codacy/reliability

@ricardobernardino2024 ricardobernardino2024 Awaiting requested review from ricardobernardino2024 ricardobernardino2024 was automatically assigned from codacy/reliability

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@afsmeira @CallMeLeopoldo